fix: properly ordered arguments of writeDataImpl#39
Open
Unisay wants to merge 2 commits intopurescript-node:masterfrom
Open
fix: properly ordered arguments of writeDataImpl#39Unisay wants to merge 2 commits intopurescript-node:masterfrom
Unisay wants to merge 2 commits intopurescript-node:masterfrom
Conversation
Author
|
By the way, |
garyb
approved these changes
Feb 7, 2025
|
@Unisay thanks for the patch! Happy to merge the fix with |
|
I guess we would need fixes for CI as well |
Author
I've fixed the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
In the foreign JS code
rl(ReadLine interface) goes first,dataStrgoes second.in the PureScript code:
Stringis applied first,Interfaceis second.This caused runtime error:
This PR fixes the error.