setting up parity with other providers#21
Merged
Conversation
Refactored code to be in line with the other providers Refactored the test cases to cover this new or removed functionality Ensured DryRun compatibilityAdded a new helper function to Find-Chocolatey rather then relying on Get-Command Removed all references to Invoke-Expression and replaced with Invoke-Command
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
DevSetup/Private/Providers/Chocolatey/Install-Chocolatey.ps1
Dismissed
Show dismissed
Hide dismissed
Pester test (On macOS) Results1 353 tests 1 352 ✅ 46s ⏱️ Results for commit 31e1201. ♻️ This comment has been updated with latest results. |
Pester test (On Linux) Results1 353 tests 1 352 ✅ 44s ⏱️ Results for commit 31e1201. ♻️ This comment has been updated with latest results. |
Summary - Pester Test Coverage ReportSummary
Coveragedevsetup - 0%
devsetup/DevSetup - 0%
devsetup/DevSetup/Private/3rdParty - 100%
devsetup/DevSetup/Private/3rdParty/VisualStudio - 100%
devsetup/DevSetup/Private/3rdParty/VisualStudioCode - 100%
devsetup/DevSetup/Private/Commands - 96.4%
devsetup/DevSetup/Private/Enums - 100%
devsetup/DevSetup/Private/Providers/Chocolatey - 100%
devsetup/DevSetup/Private/Providers/Core - 100%
devsetup/DevSetup/Private/Providers/Homebrew - 100%
devsetup/DevSetup/Private/Providers/Powershell - 100%
devsetup/DevSetup/Private/Providers/Scoop - 100%
devsetup/DevSetup/Private/Utils - 97.5%
devsetup/DevSetup/Public - 96.5%
|
The Linux and macOS test cases had some issues with lack of TestDrive and Join-Path
Corrected issue with blank paths on the test cases for linux
Pester test (On Windows) Results1 353 tests 1 352 ✅ 55s ⏱️ Results for commit 31e1201. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored code to be in line with the other providers
Refactored the test cases to cover this new or removed functionality
Ensured DryRun compatibility
Added a new helper function to Find-Chocolatey rather then relying on Get-Command
Removed all references to Invoke-Expression and replaced with Invoke-Command