Fix: Implement one _refresh_memory_dict() function

[jan-janssen]

Summary by CodeRabbit

• Refactor
  • Internal code improvements to enhance maintainability and reduce duplication. No changes to user-facing functionality.

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch refresh_memory_dict

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

 ___________________________________
< Tom & Jerry level of bug chasing. >
 -----------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).

_{✏️ Tip: You can disable in-progress messages and the fortune message in your review settings.}

Tip

You can make CodeRabbit's review stricter and more nitpicky using the `assertive` profile, if that's what you prefer.

Change the reviews.profile setting to assertive to make CodeRabbit's nitpick more issues in your PRs.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch refresh_memory_dict

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

📝 Walkthrough

Walkthrough

A helper function _refresh_memory_dict() was introduced to consolidate repeated inline memory dictionary refresh logic that appeared across three code paths. Previously, each location used dict comprehensions calling _check_task_output; now all three invoke the new centralized helper, eliminating duplication while maintaining identical behavior.

Changes

Cohort / File(s)	Summary
Memory Dictionary Refresh Refactoring src/executorlib/task_scheduler/file/shared.py	Extracted repeated inline dict comprehension logic into new _refresh_memory_dict() helper function. Helper is invoked in three previously duplicated code paths that refresh memory dictionaries by filtering completed futures. Semantic behavior unchanged; logic consolidated for maintainability.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 Three paths became one, the code whispered with glee,
No more repetition, just helpers so free,
Memory dicts refresh with elegance bright,
Refactored and tidy, everything right! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: implementing a new helper function _refresh_memory_dict() to consolidate repeated logic, which is the primary objective of this refactoring PR.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch refresh_memory_dict

---

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments

src/executorlib/task_scheduler/file/shared.py (1)

265-274: Good DRY refactor consolidating the repeated dict comprehension.

The extraction is clean and the behavior is preserved. One optional suggestion: add a brief docstring for consistency with the other private helpers in this file (e.g., _check_task_output, _convert_args_and_kwargs).

📝 Optional: add docstring

 def _refresh_memory_dict(memory_dict: dict, cache_dir_dict: dict) -> dict:
+    """
+    Refresh memory_dict by checking task outputs and removing completed futures.
+
+    Args:
+        memory_dict (dict): Mapping of task keys to their associated future objects.
+        cache_dir_dict (dict): Mapping of task keys to their cache directories.
+
+    Returns:
+        dict: Updated memory_dict with only pending (not done) futures.
+    """
     return {
         key: _check_task_output(

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}