Skip to content

Comments

Restrict input values#166

Draft
liamhuber wants to merge 7 commits intopythonworkflow:mainfrom
liamhuber:input-value-type
Draft

Restrict input values#166
liamhuber wants to merge 7 commits intopythonworkflow:mainfrom
liamhuber:input-value-type

Conversation

@liamhuber
Copy link
Contributor

To a subset of JSONifiable types, per discussion in #164.

To a subset of JSONifiable types

Signed-off-by: liamhuber <liamhuber@greyhavensolutions.com>
@liamhuber
Copy link
Contributor Author

@jan-janssen, the quantum espresso demo holds input lists of int and float. It looks to me like these should be replaced by kmesh(kx: int, ky:int, kz:int) and range(start: float, end: float, steps: int) (or similar) nodes.

@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@jan-janssen
Copy link
Member

@liamhuber I am open to clarifying an implicit restriction that we practically already used but did not enforce so far. But I am a bit more reluctant to modify the examples after publication as I feel this would break backwards compatibility. This is would require a 2.0 release.

@liamhuber
Copy link
Contributor Author

Better to use #167 as the starting point if you're going to do this, the test suite is more complete

@jan-janssen
Copy link
Member

Better to use #167 as the starting point if you're going to do this, the test suite is more complete

I am happy to merge the additional tests in #167 as well.

@liamhuber
Copy link
Contributor Author

Better to use #167 as the starting point if you're going to do this, the test suite is more complete

I am happy to merge the additional tests in #167 as well.

I disapprove of this change, but if you're going to make it anyway then the extra tests are a positive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants