Rework lesson on list, tuple, range; add enumerate & zip#639
Open
encukou wants to merge 17 commits intopyvec:masterfrom
Open
Rework lesson on list, tuple, range; add enumerate & zip#639encukou wants to merge 17 commits intopyvec:masterfrom
encukou wants to merge 17 commits intopyvec:masterfrom
Conversation
Contributor
adelpopelkova
left a comment
adelpopelkova
left a comment
There was a problem hiding this comment.
The changes look good. I really like the new parts, especially the ones with zip and enumerate. I left a few comments and suggestions, mostly fixing typos.
Glutexo
suggested changes
Aug 2, 2020
Co-authored-by: Glutexo <driezasson@me.com> Co-authored-by: adelpopelkova <59389471+adelpopelkova@users.noreply.github.com>
Co-authored-by: adelpopelkova <59389471+adelpopelkova@users.noreply.github.com>
Optimization is left as an exercise, but also given a bit later.
> „vrátí“ [vyzní] víc jako „vrátí zpátky do seznamu“ než jako „return“ Co-authored-by: Glutexo <driezasson@me.com>
encukou
added a commit
to encukou/naucse.python.cz
that referenced
this pull request
Nov 16, 2020
…e & zip) This includes some additions already in this branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's one more rework of existing lessons.
enumerate&zipare split outenumerate&ziplesson has some more focus on how iterables behave in generalenumerate&ziplesson includes unpacking inforrange, which should set the scene forenumerate&zipPlease review the changes as a whole, don't look at individual commits. But, to make cherry-picking easier, don't squash when merging.