Open
Conversation
This commit fixes an error in the codegen for API request param defined as array which reference another schema object. The generated code to parse an individual array item used the argument type (`Vec<TheType>`) so the generated code didn't compile (trying to `p.parse::<Vec<TheType>>()` instead of `p.parse::<TheType>()`).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This commit fixes an error in the codegen for API request param defined as array which references another schema object. The generated code to parse an individual array item used the argument type (
Vec<TheType>) so the generated code didn't compile (trying top.parse::<Vec<TheType>>()instead ofp.parse::<TheType>()).Tests
I'm using the following OpenAPI definition:
I would expect it to generate correct Rust code that can parse the OrderState string into an enum (it works for request body and responses).
Without the change
I'm getting the following compilation error:
With the change
Code compiles.