Skip to content

test(taskctl): add processAdversarialVerdicts state machine tests and fix stale verdict reload #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
randomm merged 3 commits into from
Feb 20, 2026
Merged

test(taskctl): add processAdversarialVerdicts state machine tests and fix stale verdict reload #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f6ae46
test(taskctl): add processAdversarialVerdicts state machine tests and…
Feb 20, 2026
adc5239
fix(test): access event.properties.taskID in pipeline test assertions
Feb 20, 2026
bdb7f7b
fix(test): scope SessionPrompt and Worktree mocks to avoid global tes…
Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions packages/opencode/src/tasks/pulse.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,14 +515,21 @@ async function processAdversarialVerdicts(jobId: string, projectId: string, pmSe
true,
)

// Reload to get task without the cleared verdict
const updatedTask = await Store.getTask(projectId, task.id)
if (!updatedTask) {
log.error("task disappeared after clearing verdict", { taskId: task.id })
continue
}

if (verdict.verdict === "APPROVED") {
await commitTask(task, projectId, pmSessionId)
await commitTask(updatedTask, projectId, pmSessionId)
} else {
const newAttempt = (task.pipeline.attempt || 0) + 1
const newAttempt = (updatedTask.pipeline.attempt || 0) + 1
if (newAttempt >= 3) {
await escalateToPM(task, jobId, projectId, pmSessionId)
await escalateToPM(updatedTask, jobId, projectId, pmSessionId)
} else {
await respawnDeveloper(task, jobId, projectId, pmSessionId, newAttempt, verdict)
await respawnDeveloper(updatedTask, jobId, projectId, pmSessionId, newAttempt, verdict)
}
}
}
Expand Down
Loading