Skip to content

Comments

fix(taskctl): clear assignee on developing→reviewing transition and add happy path integration test#258

Merged
randomm merged 1 commit intodevfrom
fix/issue-257-pulse-happy-path
Feb 20, 2026
Merged

fix(taskctl): clear assignee on developing→reviewing transition and add happy path integration test#258
randomm merged 1 commit intodevfrom
fix/issue-257-pulse-happy-path

Conversation

@randomm
Copy link
Owner

@randomm randomm commented Feb 20, 2026

Fixes #257

Root Cause

heartbeatActiveAgents was not clearing assignee and assignee_pid when transitioning a task from stage: developing to stage: reviewing. The spawnAdversarial filter requires !t.assignee — so the adversarial agent was never spawned, leaving tasks stuck at developing forever.

Fix

  • heartbeatActiveAgents: clear assignee: null, assignee_pid: null on developing→reviewing transition
  • Export heartbeatActiveAgents and scheduleReadyTasks for test access
  • Add allowImmutable: true to Store.updateTask calls that modify pipeline field

Test

New integration test pulse-happy-path.test.ts drives the complete flow:
scheduleReadyTasks → developing → heartbeat → reviewing → spawnAdversarial → APPROVED → done

@randomm randomm merged commit 03bcf58 into dev Feb 20, 2026
1 check passed
@randomm randomm deleted the fix/issue-257-pulse-happy-path branch February 20, 2026 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(taskctl): integration test for full Pulse happy path — developing→reviewing→adversarial

1 participant