Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #259, #260
Problems Fixed
Bug 1: Missing taskctl permission (#259)
adversarial-pipeline had
"*": "deny"with no taskctl exception. The taskctl MCP tool was completely blocked — the agent could never submit a verdict regardless of prompt instructions.Fix: Added
taskctl: "allow"to adversarial-pipeline permissions.Bug 2: Wrong prompt syntax (#259)
Prompt instructed the agent to call
taskctl verdict <taskId> --verdict APPROVED(CLI bash syntax). The agent correctly identified it couldn't find the binary and gave up.Fix: Updated prompt to describe taskctl as an MCP tool with correct parameter names (command, taskId, verdict, verdictSummary, verdictIssues).
Tests Added (#260)
New
test/tasks/agent-permissions.test.ts: