Add close popup when click iframe for click trigger#96
Open
stephen-james wants to merge 1 commit intoreact-component:masterfrom
Open
Add close popup when click iframe for click trigger#96stephen-james wants to merge 1 commit intoreact-component:masterfrom
click trigger#96stephen-james wants to merge 1 commit intoreact-component:masterfrom
Conversation
Using Trigger with `contextMenu` supports closing on window blur, in order to cover when a user clicks/taps on an iframe, but when we use `click` as a trigger, this was previously not supported. This fix modifies the handler to support both click and contextMenu as valid triggers. * simulates document click on window blur for both click and contextMenu triggers * `contextMenuOutsideHandler1` renamed to `contextMenuScrollOutsideHandler` to be more descriptive about what case it is handling. * `contextMenuOutsideHandler2` renamed to `clickBlurOutsideHandler` since it is the handler for click and contextMenu triggers (similar to `clickOutsideHandler`)
zombieJ
reviewed
May 3, 2019
| if (!this.contextMenuScrollOutsideHandler && this.isContextMenuToShow()) { | ||
| currentDocument = currentDocument || props.getDocument(); | ||
| this.contextMenuOutsideHandler1 = addEventListener(currentDocument, | ||
| this.contextMenuScrollOutsideHandler = addEventListener(currentDocument, |
Member
There was a problem hiding this comment.
Sorry for delay. contextMenuScrollOutsideHandler should get remove after unmounted. And also need a test case for this.
|
I also encountered this issue, could this PR get merged? |
|
how can we trigger this in an iframe? |
|
@zombieJ Can you please check on this. I have the same issue with iframe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using Trigger with
contextMenusupports closing on window blur, in order to cover when a user clicks/taps on an iframe, but when we useclickas a trigger, this was previously not supported.This fix modifies the handler to support both click and contextMenu as valid triggers.
contextMenuOutsideHandler1renamed tocontextMenuScrollOutsideHandlerto be more descriptive about what case it is handling.contextMenuOutsideHandler2renamed toclickBlurOutsideHandlersince it is the handler for click and contextMenu triggers (similar toclickOutsideHandler)