refactor: Optimizing access to header values in default request#430
refactor: Optimizing access to header values in default request#430winie wants to merge 2 commits intoreact-component:masterfrom
Conversation
When iterating over header values with array functions, the header values are passed directly to the array function.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Could you provide reproduce and add a test case for it? |
Codecov Report
@@ Coverage Diff @@
## master #430 +/- ##
==========================================
- Coverage 84.92% 84.86% -0.07%
==========================================
Files 6 6
Lines 252 251 -1
Branches 63 59 -4
==========================================
- Hits 214 213 -1
Misses 38 38
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
fe2cf2a to
6be7fba
Compare
The behaviour of the component has not changed. I only replaced the for-loops in the request.ts with more modern iterations. Therefore, the previous tests should be sufficient. If you mean the 0.07% lost percentage of test coverage: |
When iterating over header values with array functions, the header values are passed directly to the array function.