修复拖拽不符合要求的文件，仍然调用beforeUpload by meiyuanReact · Pull Request #627 · react-component/upload

meiyuanReact · 2025-05-28T10:00:17Z

Summary by CodeRabbit

修复问题
- 修正了上传文件时的筛选逻辑，确保在仅允许单文件上传时，只会上传通过类型校验的第一个文件。
- 增加了拖拽上传时对不接受文件类型的处理测试，确保不会触发上传开始回调。

vercel · 2025-05-28T10:00:23Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
upload	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 27, 2025 3:20pm

coderabbitai · 2025-05-28T10:00:25Z

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

📥 Commits

Reviewing files that changed from the base of the PR and between e5ea51a and 2c033b0.

📒 Files selected for processing (1)

tests/uploader.spec.tsx (1 hunks)

 __________________________________________________________________________________________________________________________________________________________________________________________________________________
< In software, we rarely have meaningful requirements. Even if we do, the only measure of success that matters is whether our solution solves the customer's shifting idea of what their problem is. - Jeff Atwood >
 ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       / 　 づ

Walkthrough

本次更改调整了在处理数据传输上传时对可接受文件的筛选逻辑。现在，当不允许多选文件时，将从已通过类型筛选的文件数组中选择第一个文件，而不是原始文件数组，确保文件类型过滤优先于数量限制。此外，新增测试用例验证拖入不被接受类型文件时不会触发上传开始回调。

Changes

文件/文件组	变更摘要
src/AjaxUploader.tsx	修改文件筛选逻辑，先按类型过滤，再应用数量限制。
tests/uploader.spec.tsx	新增测试，验证拖入不接受类型文件时不触发上传开始事件。

Possibly related PRs

fix: Upload drag & drop not working #625：同样修改了 onDataTransferFiles 方法中对文件筛选和选择的逻辑，关注文件类型过滤与多选限制的关系。

Poem

兔子跳跃键盘前，
代码筛选更周全。
先查类型后计数，
上传文件不混乱。
逻辑清晰如晨露，
🐇为你鼓掌欢！

Tip

CodeRabbit can approve the review once all CodeRabbit's comments are resolved.

Enable the reviews.request_changes_workflow setting in your project's settings in CodeRabbit to automatically approve the review once all CodeRabbit's comments are resolved.

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate Unit Tests

❌ Error creating Unit Test PR.

Create PR with Unit Tests
Commit Unit Tests in branch patch-1
Post Copyable Unit Tests in Comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai auto-generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

afc163 · 2025-05-29T06:25:58Z

需要测试用例。

codecov · 2025-05-29T06:27:02Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.10%. Comparing base (f1e3790) to head (2c033b0).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #627   +/-   ##
=======================================
  Coverage   89.10%   89.10%           
=======================================
  Files           6        6           
  Lines         303      303           
  Branches       80       84    +4     
=======================================
  Hits          270      270           
  Misses         33       33

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

补充UT

meiyuanReact · 2025-06-27T11:07:14Z

已补充drag unaccepted type files with multiple false to upload will not trigger onStart来测试当multiple=false的时候上传不符合要求的文件不触发onStart事件

Copilot

Pull Request Overview

This PR aims to fix an issue where dragging files that do not meet the acceptance criteria still triggered the beforeUpload callback. The changes include updating the file filtering logic in AjaxUploader to only slice accepted files when multiple file uploads are disabled and adding tests to verify that unaccepted file types do not trigger the onStart callback.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
tests/uploader.spec.tsx	Added a test case for drag-and-drop behavior when files of an unaccepted type are dropped with multiple set to false.
src/AjaxUploader.tsx	Modified filtering logic to slice the accepted files array instead of the raw files array when multiple is false.

tests/uploader.spec.tsx

afc163 · 2025-06-27T15:13:09Z

@coderabbitai full review

coderabbitai · 2025-06-27T15:13:15Z

✅ Actions performed

Full review triggered.

coderabbitai · 2025-06-27T15:19:54Z

Caution

No docstrings were generated.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

coderabbitai · 2025-06-27T15:22:25Z

Note

Unit test generation is an Early Access feature. Expect some limitations and changes as we gather feedback and continue to improve it.

Generating unit tests... This may take up to 20 minutes.

afc163 · 2025-06-27T15:29:15Z

tests/uploader.spec.tsx

+        expect(mockStart.mock.calls.length).toBe(0);
+        done();
+      }, 100);
+    });


是不是应该检测 beforeUpload 的触发情况？

afc163 · 2025-06-27T15:34:59Z

看 ant-design/ant-design#36318 (comment) 这里的表达，拖拽或选择非 accept 文件也触发 beforeUpload 好像才是符合预期的？

修复拖拽不符合要求的文件，仍然调用beforeUpload

6b3d0d3

vercel bot deployed to Preview May 28, 2025 10:00 View deployment

Update uploader.spec.tsx

e5ea51a

补充UT

vercel bot deployed to Preview June 27, 2025 11:05 View deployment

afc163 requested review from Copilot and zombieJ June 27, 2025 15:11

Copilot AI reviewed Jun 27, 2025

View reviewed changes

tests/uploader.spec.tsx Outdated Show resolved Hide resolved

afc163 approved these changes Jun 27, 2025

View reviewed changes

Update tests/uploader.spec.tsx

2c033b0

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

vercel bot deployed to Preview June 27, 2025 15:20 View deployment

afc163 reviewed Jun 27, 2025

View reviewed changes

coderabbitai bot mentioned this pull request Jun 27, 2025

CodeRabbit Generated Unit Tests: Add comprehensive uploader.spec.tsx tests for edge cases and accessibility #638

Open

Uh oh!

Conversation

meiyuanReact commented May 28, 2025 • edited by afc163 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

vercel bot commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

afc163 commented May 29, 2025

Uh oh!

codecov bot commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

meiyuanReact commented Jun 27, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

afc163 commented Jun 27, 2025

Uh oh!

coderabbitai bot commented Jun 27, 2025

Uh oh!

coderabbitai bot commented Jun 27, 2025

Uh oh!

coderabbitai bot commented Jun 27, 2025

Uh oh!

afc163 Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

afc163 commented Jun 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

meiyuanReact commented May 28, 2025 •

edited by afc163

Loading

vercel bot commented May 28, 2025 •

edited

Loading

coderabbitai bot commented May 28, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented May 29, 2025 •

edited

Loading