ExtendedPromiseInterface: type-hint for then()#202
ExtendedPromiseInterface: type-hint for then()#202Thomas-Gelf wants to merge 1 commit intoreactphp:2.xfrom
Conversation
This solves the problem that a PHP IDE always believes your then() method returns a PromiseInterface and not an ExtendedPromiseInterface
23eaa09 to
029fe3f
Compare
|
@Thomas-Gelf thanks for looking into this 👍 It's not 100% guaranteed that this will always return a ExtendedPromiseInterface. I discussed this with @clue and maybe there should be something like What do you think about this? |
|
This pull request here shouldn't be needed anymore with Promise v3 out, as we added template types and improved type safety in general in #246, #247 and others. The functionality of the This is why I'll go ahead and close this ticket here, thanks for the contribution 👍 |
This solves the problem that a PHP IDE always believes your then()
method returns a PromiseInterface and not an ExtendedPromiseInterface