Run tests on PHP 8.4 and update test environment#268
Closed
PaulRotmann wants to merge 1 commit intoreactphp:3.xfrom
Closed
Run tests on PHP 8.4 and update test environment#268PaulRotmann wants to merge 1 commit intoreactphp:3.xfrom
PaulRotmann wants to merge 1 commit intoreactphp:3.xfrom
Conversation
clue
requested changes
Aug 8, 2025
Member
There was a problem hiding this comment.
@PaulRotmann Thanks for looking into this, changes look reasonable 👍
However, besides the PHPstan update discussed in #267, the test suite currently reports one error on PHP 8.4+ only:
There was 1 failure:
1) /home/runner/work/promise/promise/tests/FunctionSetRejectionHandlerThatTriggersDefaultHandlerShouldTerminateProgramForUnhandled.phpt
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
-Fatal error: Unexpected RuntimeException: foo in %s line %d
+Deprecated: Passing E_USER_ERROR to trigger_error() is deprecated since 8.4, throw an exception or call exit with a string message instead in /home/runner/work/promise/promise/tests/FunctionSetRejectionHandlerThatTriggersDefaultHandlerShouldTerminateProgramForUnhandled.php on line 9
+
+Fatal error: Unexpected RuntimeException: foo in /home/runner/work/promise/promise/tests/FunctionSetRejectionHandlerThatTriggersDefaultHandlerShouldTerminateProgramForUnhandled.php on line 9
/home/runner/work/promise/promise/tests/FunctionSetRejectionHandlerThatTriggersDefaultHandlerShouldTerminateProgramForUnhandled.phpt:24
Here's some background info:
Calling trigger_error() with error_level being equal to E_USER_ERROR is now deprecated.
This only affects a single test that specifically tests how the rejection logic behaves when a custom function using this (deprecated) functionality is used. Accordingly, we should probably skip the affected test on PHP 8.4+ (originally introduced in #249):
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #267, #261, #255 and others.
Also this PR resolves #266.