Register RectorConfig in container and set static instance to ensure singleton instance of RectorConfig

[guanguans]

issue: RectorConfig is injected via constructor, it is a new RectorConfig empty container instance.

use PhpParser\Node;
use Rector\Config\RectorConfig;
use Rector\Rector\AbstractRector;

final class FooRector extends AbstractRector
{
    private RectorConfig $rectorConfig;

    public function __construct(RectorConfig $rectorConfig)
    {
        // It is a new RectorConfig empty container instance.
        $this->rectorConfig = $rectorConfig;
    }

    public function getNodeTypes(): array
    {
        // ...
    }

    public function refactor(Node $node): ?Node
    {
        // ...
    }
}

[Copilot]

Pull request overview

This PR fixes an issue where custom Rector rules that inject RectorConfig via constructor were receiving an empty instance instead of the properly configured container. The fix ensures that the RectorConfig instance created in LazyContainerFactory::create() is registered both as a static singleton and as a container instance.

Changes:

• Register RectorConfig as static singleton using setInstance() to enable global access via Container::getInstance()
• Register RectorConfig in the container itself using instance() to enable dependency injection

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[samsonasik]

Why you need it? RectorConfig should not be injected in rector rule, you can configure via implements ConfigurableRectorInterface in the rector rule itself

[guanguans]

@samsonasik I want to get the container instance more flexible to handle something, unrelated to the ConfigurableRectorInterface, something like this code:

<?php

use PhpParser\Node;
use Rector\Config\RectorConfig;
use Rector\Rector\AbstractRector;

abstract class AbstractProxyRector extends AbstractRector
{
    protected AbstractRector $proxyRector;

    /**
     * @throws \Illuminate\Contracts\Container\BindingResolutionException
     */
    public function __construct(RectorConfig $rectorConfig)
    {
        // RectorConfig::getInstance();
        $this->proxyRector = clone $rectorConfig->make($this->proxyRectorClass());
    }

    /**
     * {@inheritDoc}
     */
    public function refactor(Node $node)
    {
        // ...
    }

    /**
     * @return class-string<\Rector\Rector\AbstractRector>
     */
    abstract protected function proxyRectorClass(): string;
}

[TomasVotruba]

RectorConfig is exclusively internal. Injecting container to rule is a bad practice.
What exactly is your issue/goal?