Show quick fix to rename references for modifying symbol name manually #2959
Open
CsCherrYY wants to merge 1 commit intoredhat-developer:mainfrom
Open
Show quick fix to rename references for modifying symbol name manually #2959CsCherrYY wants to merge 1 commit intoredhat-developer:mainfrom
CsCherrYY wants to merge 1 commit intoredhat-developer:mainfrom
Conversation
CsCherrYY
force-pushed
the
cs-rename-reference
branch
from
6db6503 to
6a59007
Compare
CsCherrYY
force-pushed
the
cs-rename-reference
branch
from
6a59007 to
f386cc2
Compare
Signed-off-by: Shi Chen <chenshi@microsoft.com>
CsCherrYY
force-pushed
the
cs-rename-reference
branch
from
30989b0 to
118e93e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requires eclipse-jdtls/eclipse.jdt.ls#2487
When auto-build is disabled, there will be no diagnostics from the references when modifying a public symbol manually (e.g., change method name from "test" to "test1"). It might lead to mistakes.
This PR will provide an info diagnostic and related quick fix to rename all the references when modifying a symbol name. The configuration
java.refactoring.rename.referencescontrols this. When it set toauto, this behavior will only happen when auto build is disabled.demo:
renameReferneces.mp4