Update response.send() to check HTTP status code length#1722
Open
Adimvicky wants to merge 1 commit intorestify:masterfrom
Open
Update response.send() to check HTTP status code length#1722Adimvicky wants to merge 1 commit intorestify:masterfrom
Adimvicky wants to merge 1 commit intorestify:masterfrom
Conversation
I updated line 300 which checks that the HTTP status code passed into the Response.send() function is of type "number" to also check that the length of the status code is equal to three since all HTTP status codes are three digits. This allows for the Response.send() function to send ordinary numbers of any length ( other than three ) as response if need be.
3 tasks
sean3z
suggested changes
Jan 11, 2019
Contributor
There was a problem hiding this comment.
The contribution is greatly appreciated!! 🙂
Certainly an interesting approach! I'm thinking this will become confusing for restify consumers though - especially since the api would only allow numbers, 0-99 and 1000+; leaving 100-999 off-limits.
I know this has been a hot topic before but, will likely require a slightly more sophisticated solve
|
I don't think this would be a good feature like it is...
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated line 300 which checks that the HTTP status code passed into the Response.send() function is of type "number" to also check that the length of the status code is equal to three since all HTTP status codes are three digits. This allows for the Response.send() function to send ordinary numbers of any length ( other than three ) as response if need be, instead of throwing.
Pre-Submission Checklist
make prepushIssues
Closes:
Changes