Implemented Arbitrary Parameters match from Path#4
Open
cstayyab wants to merge 2 commits intoriverside:masterfrom
Open
Implemented Arbitrary Parameters match from Path#4cstayyab wants to merge 2 commits intoriverside:masterfrom
cstayyab wants to merge 2 commits intoriverside:masterfrom
Conversation
Author
|
@riverside Can you please review and merge it so it can be published and used from composer? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now we can provide arbitrary and multiple parameters name in URL Path.
Example
This will output the resultant Request Object in JSON format where we can see the
paramsarray providingusernameandid{ "app": { "router": {} }, "body": [], "cookies": [], "files": [], "hostname": "localhost", "ip": "::1", "method": "GET", "originalUrl": "/user/cstayyab/pictures/2", "params": { "username": "cstayyab", "id": "2" }, "path": "user/cstayyab/pictures/2", "port": "80", "protocol": "HTTP/1.1", "query": [], "route": "", "scheme": "http", "secure": false, "session": null, "xhr": 0 }Future Work
In future we can provide an option to pass custom regex expression like this:
Fixes #3