Apply packaging.tags patch to pip's vendored version#129
Merged
virtuald merged 3 commits intorobotpy:mainfrom Sep 13, 2025
Merged
Apply packaging.tags patch to pip's vendored version#129virtuald merged 3 commits intorobotpy:mainfrom
virtuald merged 3 commits intorobotpy:mainfrom
Conversation
Member
Author
|
I noticed my initial patch actually breaks existing behavior... but I think it's the correct fix, but probably should be documented? With this patch, if no platform tags are reported, Previously, I think this is because the unpatched version of I think the correct behavior is that if a user specifies |
2d59977 to
ff7724f
Compare
Closed
- This means if you specify one platform tag, you must specify all of the tags that you need to support
ff7724f to
5cab2ce
Compare
5cab2ce to
bad6536
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would love a release with this. We use a custom platform tag for our wheels so they only install on our controller, but we also want to be able to leverage normal wheels for our architecture too. This allows that to happen.