Open
Conversation
Member
|
I think this looks good. There may be some rough edges to smooth out for cases where you do not use all 3 OAuth providers. Most of those look like you could add some simple checks like you did in the application helper, probably with the exception of the user model. If those checks end up being useful in other places maybe you could do something in an initializer and add them to the application's config. Maybe something like this: # config/initializers/oauth_providers.rb
Rails.application.config.oauth_providers = ActiveSupport::OrderedOptions.new
Rails.application.config.oauth_providers.github = ENV['GITHUB_KEY'].present?
Rails.application.config.oauth_providers.google = ENV['GOOGLE_OAUTH_CLIENT_ID'].present?
Rails.application.config.oauth_providers.twitter = ENV['TWITTER_KEY'].present?We actually have a gem at TCS that does something similar to this. We load a YAML file and the gem then knows how to get data from the environment, consul, or vault. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently a WIP but the basic flow works.