Open
Conversation
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.13 introduced the
show_emptykeyword argument toast.dump. Ifshow_emptyisFalse,ast.dumpomits empty lists and fields that areNonefrom its output.Since
show_empty=Falseis the default in Python 3.13 andast.dumppreviously behaved likeshow_empty=True, thetest_ast_exprtest currently fails for Python ≥3.13.Assuming
devtoolswants to keep the default behavior ofast.dump, I've split thetest_ast_exprtest into two parts, one testing for the default behavior under Python <3.13, one testing for the default behavior under Python ≥3.13.See also: https://hydra.nixos.org/build/294880588/nixlog/2/tail