build arm images on arm workers#29
Open
minrk wants to merge 1 commit intoscientificcomputing:mainfrom
Open
Conversation
Member
|
We also thought about this @minrk. |
Contributor
Author
|
Nice, I think that probably is simpler |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
now that we have native arm workers, I think this should work the same as using circleci for arm, but all on GHA with a simpler task graph.
I really feel like this should be simpler, and deleting the intermediates still don't seem to work due to permission issues. Maybe there's a way to merge manifests before pushing, but we need to get the manifest from the build job to the publish job.