Skip to content

several utility enhancements#7098

Open
Goober5000 wants to merge 1 commit intoscp-fs2open:masterfrom
Goober5000:utility_enhancements
Open

several utility enhancements#7098
Goober5000 wants to merge 1 commit intoscp-fs2open:masterfrom
Goober5000:utility_enhancements

Conversation

@Goober5000
Copy link
Contributor

@Goober5000 Goober5000 commented Oct 24, 2025

These were coded for the split_str refactor, but are generally useful elsewhere as well.

  1. Use SCP_string in some utility functions where appropriate
  2. Avoid copying C-strings in some utility functions where it isn't necessary
  3. Add concat functions to SCP_vector
  4. Change return type int to bool on some common parselo functions
  5. Add find_white_space and find_gray_space parselo functions

Depends on #7097; in draft until that is merged.

@Goober5000 Goober5000 added cleanup A modification or rewrite of code to make it more understandable or easier to maintain. Waiting for Stable Marks a pull request that is to be merged after the next stable release, due to a release cycle labels Oct 24, 2025
@Goober5000 Goober5000 force-pushed the utility_enhancements branch 6 times, most recently from 49bb7d9 to fb8551f Compare October 26, 2025 03:46
@Goober5000 Goober5000 force-pushed the utility_enhancements branch from fb8551f to 041dd2b Compare November 5, 2025 05:26
@Goober5000 Goober5000 marked this pull request as ready for review February 13, 2026 06:05
@Goober5000 Goober5000 removed the Waiting for Stable Marks a pull request that is to be merged after the next stable release, due to a release cycle label Feb 13, 2026
These were coded for the `split_str` refactor, but are generally useful elsewhere as well.

1. Use SCP_string in some utility functions where appropriate
2. Avoid copying C-strings in some utility functions where it isn't necessary
3. Add concat functions to `SCP_vector`
4. Change return type `int` to `bool` on some common parselo functions
5. Add `find_white_space` and `find_gray_space` parselo functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup A modification or rewrite of code to make it more understandable or easier to maintain.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant