Remove commons-lang3 dependency from core module #802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commons-lang3 was pulled in transitively via the optional gremlin-core dependency but used directly in production code (DefaultLoadBalancingPolicy). Since gremlin-core is optional, consumers would not get commons-lang3 transitively, risking NoClassDefFoundError at runtime. Replace Pair<Integer, Integer> with int[] in moveReplicasToFront() and ArrayUtils.addAll() with standard Arrays.copyOf()/System.arraycopy() in VectorCodecTest.
Fix pre-existing xml-format-maven-plugin check failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
commons-lang3was a transitive dependency of the optionalgremlin-corebut used directly in production code (DefaultLoadBalancingPolicy), meaning consumers could hitNoClassDefFoundErrorat runtime if they didn't happen to have it on their classpathPair<Integer, Integer>withint[]inmoveReplicasToFront()— the only production usageArrayUtils.addAll()withArrays.copyOf()/System.arraycopy()inVectorCodecTest— the only test usageCloses: #801
Test plan
DefaultLoadBalancingPolicy*tests pass (232 tests)VectorCodecTestpasses (131 tests)