Refactor FalconMamba: replace class-name checks with generic attribute detection#424
Draft
Refactor FalconMamba: replace class-name checks with generic attribute detection#424
Conversation
…config, 'use_mambapy') Co-authored-by: xadupre <22452781+xadupre@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor code for FalconMamba model
Refactor FalconMamba: replace class-name checks with generic attribute detection
Feb 23, 2026
Collaborator
|
unittest? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The codebase had hard-coded
config.__class__.__name__ == "FalconMambaConfig"checks in three places intext_generation.py, tightly coupling Mamba-model handling to a single model class.Changes
config.__class__.__name__ == "FalconMambaConfig"guards withhasattr(config, "use_mambapy")— the attribute already cited incheck_hasattrcalls as the Mamba-model indicator, making the branches work for any Mamba-based config, not justFalconMambaConfig._get_input_falcon_mamba→_get_input_mambato reflect its model-agnostic role.Affected functions:
reduce_model_config,get_inputs,random_input_kwargs.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.