Closed
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses GitHub issue 515 by improving retry logic and error logging in the Segment Analytics SDK. The changes focus on fixing the indentation of a return statement and enhancing retry behavior with better logging and attempt tracking.
- Fixed indentation bug where
return successwas incorrectly inside the finally block - Added retry attempt logging with backoff details via
on_backoffcallback - Implemented attempt counting to log final error after exhausting all retries
- Commented out redundant error logging in request.py
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| segment/analytics/request.py | Commented out redundant error logging before re-raising exception, cleaned up trailing whitespace |
| segment/analytics/consumer.py | Fixed return statement indentation bug, added retry attempt tracking and logging, added backoff callback for debugging |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves error handling and logging for retry attempts in the analytics consumer, making it easier to debug and monitor request failures. The changes include enhanced retry logging, better reporting when all retries are exhausted, and a minor update to exception logging.
Error handling and retry improvements:
send_requestfunction, including the attempt number and elapsed time.