Open
Conversation
added 5 commits
April 18, 2023 08:48
SendGrid now allows for multiple webhooks and this PR pulls in the non-breaking API changes to support it. Webhook resources will now take an ID parameter to target specific webhooks. When a webhook resource is NOT used with an ID, the API falls back to legacy behavior assuming there is only one webhook, and this defaults to the oldest webhook available. Users should update their services to reference webhooks by ID.
|
Hi @sethgrid , regarding the failing test. We are using stoplight/prism to create a mock server for integration tests. These are the test where the changes were made and are failing. Prism uses oai_stoplight.json to mock the api. These configurations are imported here. This needs to be updated to adhere to the recent webhook changes. Also this needs to be updated to fetch the latest changes in oai_stoplight.json instead of from a particular commit. After the changes are done in sendgrid-oai. We can test this locally in sendgrid/python by running make test-docker command |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SendGrid now allows for multiple webhooks and this PR pulls in the non-breaking API changes to support it.
Webhook resources will now take an ID parameter to target specific webhooks. When a webhook resource is NOT used with an ID, the API falls back to legacy behavior assuming there is only one webhook, and this defaults to the oldest webhook available. Users should update their services to reference webhooks by ID.
Checklist
If you have questions, please file a support ticket.