Push notifications: finalize client implementation and document server requirements#40
Open
Push notifications: finalize client implementation and document server requirements#40
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: argyleink <1134620+argyleink@users.noreply.github.com>
Co-authored-by: argyleink <1134620+argyleink@users.noreply.github.com>
…worker URL construction Co-authored-by: argyleink <1134620+argyleink@users.noreply.github.com>
Co-authored-by: argyleink <1134620+argyleink@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add push notifications for new episodes with bell icon
Add native push notification support for new episodes
Feb 8, 2026
- Send welcome notification when user subscribes with brand logo - Enhance service worker to support episode art and detailed info - Move bell icon from standalone to first position in platforms list - Remove padding to match platform icon styling Co-authored-by: argyleink <1134620+argyleink@users.noreply.github.com>
…y undefined - Use show title prop instead of hardcoded podcast name - Remove unnecessary 'image: undefined' from defaults - Pass show title from Platforms component to button Co-authored-by: argyleink <1134620+argyleink@users.noreply.github.com>
- Document welcome notification feature - Describe episode artwork support - Update bell icon location description - Add example notification payload - Clarify production integration Co-authored-by: argyleink <1134620+argyleink@users.noreply.github.com>
Copilot
AI
changed the title
Add native push notification support for new episodes
Add welcome notification and relocate bell to platform icons
Feb 8, 2026
- Create new bell.svg with simpler, cleaner design - Switch from inline SVG to mask-image technique - Apply gradient-icon class for consistent colors with other platform icons - Use opacity to differentiate subscribed/unsubscribed states - Maintain hover effects consistent with other icons Co-authored-by: argyleink <1134620+argyleink@users.noreply.github.com>
Copilot
AI
changed the title
Add welcome notification and relocate bell to platform icons
Replace bell icon with cleaner SVG and fix color mismatch
Feb 8, 2026
- Move bell icon to last position in platforms list - Remove console logs except in dev mode (both client and service worker) - Add keyboard hotkey (Ctrl+Shift+P) for test notifications - Complete all TODOs with environment variable support - Add comprehensive PUSH_NOTIFICATIONS.md documentation - Verify all image paths are valid - Document 12 push notification opportunities - List all remaining server-side tasks Co-authored-by: argyleink <1134620+argyleink@users.noreply.github.com>
Copilot
AI
changed the title
Replace bell icon with cleaner SVG and fix color mismatch
Push notifications: finalize client implementation and document server requirements
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Client-side push notification implementation had incomplete server integration points, debugging logs in production, and missing testing capability. Server requirements were undocumented.
Changes
Client Polish
isDevchecks (client usesimport.meta.env.DEV, service worker checks hostname)Ctrl+Shift+P/Cmd+Shift+Ptriggers test notification with realistic episode content and artwork/android-chrome-192x192.png,/favicon-32x32.png,/android-chrome-384x384.png) existServer Integration (TODOs → Implementation)
Replaced placeholder TODOs with environment variable support and API integration:
Environment variables:
PUBLIC_VAPID_KEY,VAPID_PRIVATE_KEY,PUBLIC_API_URLDocumentation (
PUSH_NOTIFICATIONS.md)Environment Configuration
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.