Open
Conversation
nheeb
approved these changes
Feb 20, 2026
| } | ||
|
|
||
| function filterFunction() { | ||
| var input, filter, ul, li, a, i; |
There was a problem hiding this comment.
Suggested change
| var input, filter, ul, li, a, i; | |
| var input, filter, a, i; |
Comment on lines
+36
to
+43
| const policyTemp = document.querySelector("#policy"), | ||
| policyDiv = document.querySelector("#sw-policies"), | ||
| filterTemp = document.querySelector("#filter"), | ||
| filterDropdown = document.querySelector("#filterDropdown"); | ||
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Suggested change
| const policyTemp = document.querySelector("#policy"), | |
| policyDiv = document.querySelector("#sw-policies"), | |
| filterTemp = document.querySelector("#filter"), | |
| filterDropdown = document.querySelector("#filterDropdown"); | |
| const policyTemp = document.querySelector("#policy"); | |
| const policyDiv = document.querySelector("#sw-policies"); | |
| const filterTemp = document.querySelector("#filter"); | |
| const filterDropdown = document.querySelector("#filterDropdown"); |
There was a problem hiding this comment.
In general this way of creating multiple vars with the "," looks so cursed to me.
| filterDropdown.appendChild(filter); | ||
| polcolor.id += '_'+policyId; | ||
| polcolor.style.background = colorPolicies[policyId]; | ||
| console.log(colorPolicies); |
There was a problem hiding this comment.
Suggested change
| console.log(colorPolicies); | |
| // console.log(colorPolicies); |
| polcolor = policy.querySelector("#color"), | ||
| pconforms = policy.querySelector("#policy-conforms"); | ||
| const policyId = Object.keys(pol)[0]; | ||
| console.log(policyId); |
There was a problem hiding this comment.
Suggested change
| console.log(policyId); | |
| // console.log(policyId); |
Comment on lines
+111
to
+120
| //Extend Checkbox for metadata source | ||
| const checkbox = document.querySelector("#extended"); | ||
| checkbox.addEventListener('change', (event)=>{ | ||
| if(checkbox.checked){ | ||
| document.getElementById("col2").style.visibility = ""; | ||
| }else{ | ||
| document.getElementById("col2").style.visibility = "collapse"; | ||
| } | ||
|
|
||
| }) |
There was a problem hiding this comment.
Suggested change
| //Extend Checkbox for metadata source | |
| const checkbox = document.querySelector("#extended"); | |
| checkbox.addEventListener('change', (event)=>{ | |
| if(checkbox.checked){ | |
| document.getElementById("col2").style.visibility = ""; | |
| }else{ | |
| document.getElementById("col2").style.visibility = "collapse"; | |
| } | |
| }) | |
| //Extend Checkbox for metadata source | |
| const checkbox = document.querySelector("#extended"); | |
| checkbox.addEventListener('change', (event)=>{ | |
| if(checkbox.checked){ | |
| document.getElementById("col2").style.visibility = ""; | |
| }else{ | |
| document.getElementById("col2").style.visibility = "collapse"; | |
| } | |
| }) |
| const element = document.createElement("div"); | ||
| element.appendChild(document.createTextNode(` ${JSON.stringify(e).replaceAll("{","").replaceAll("}","").replaceAll('"',"")}`)); | ||
| div.appendChild(element); | ||
| function extract_info(cell, obj, tag, colorPolicies){ |
There was a problem hiding this comment.
In curation.js line 90 this method gets calles with only 2 parameters. Is that possible in JavaScript and is that intended?
There was a problem hiding this comment.
I guess those files with the (1) can be deleted?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13