fix(escrow-native): prevent rent refund redirection#533
Open
yukikm wants to merge 1 commit intosolana-developers:mainfrom
Open
fix(escrow-native): prevent rent refund redirection#533yukikm wants to merge 1 commit intosolana-developers:mainfrom
yukikm wants to merge 1 commit intosolana-developers:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses critical security vulnerabilities related to lamport manipulation in Solana programs. The primary focus is on the escrow native program, with additional security hardening in the transfer-sol anchor example.
Changes:
- Fixed rent refund redirection vulnerability in escrow: rent from closed offer accounts now goes to the maker (initializer) instead of an arbitrary payer
- Corrected post-transfer balance assertion bug in escrow that was checking the wrong variable
- Enhanced transfer-sol/anchor with signer validation and overflow protection for direct lamport transfers
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tokens/escrow/native/program/src/instructions/take_offer.rs | Refunds offer rent to maker instead of payer; fixes balance assertion to use correct pre-transfer variable |
| tokens/escrow/native/tests/instruction.ts | Makes maker account writable to receive rent refund |
| tokens/escrow/native/tests/test.ts | Adds comprehensive regression test proving rent cannot be redirected to attacker-controlled payer |
| basics/transfer-sol/anchor/programs/transfer-sol/src/lib.rs | Adds Signer constraint, checked arithmetic for overflow protection, and explicit balance validation |
| basics/transfer-sol/anchor/tests/test.ts | Adds required signer to match updated program constraints |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
7ae7235 to
0e0cf8b
Compare
Author
|
Note: GitHub Copilot “Pull request overview” currently mentions changes under Source of truth patch (shows the actual diff): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two issues in
tokens/escrow/native:payeraccount. The rent is now refunded to the maker (offer initializer).Adds a regression test proving the rent refund cannot be redirected.