Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
🤖 Augment PR SummarySummary: This PR updates the vendored Changes:
Technical Notes: The upgrade introduces API signature changes (callbacks + 🤖 Was this summary useful? React with 👍 or 👎 |
| -> std::size_t { | ||
| #if defined(__SIZEOF_INT128__) | ||
| const auto *parts = | ||
| reinterpret_cast<const std::uint64_t *>(&hash.a); // NOLINT |
There was a problem hiding this comment.
reinterpret_cast<const std::uint64_t *>(&hash.a) risks strict-aliasing UB (and can also accidentally read into padding/adjacent fields depending on hash_type layout), which could miscompile the Hasher and break unordered container lookups.
Severity: high
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| } | ||
|
|
||
| static const JSON::String REF{"$ref"}; | ||
| base.push_back(REF); |
There was a problem hiding this comment.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com