Add export mappings for entity class, entity and parameter descriptions#613
Merged
Add export mappings for entity class, entity and parameter descriptions#613
Conversation
The new description mappings were added to mapping settings where they make sense, i.e. the ones where we export only entity classes and/or entities. Having them part of e.g. parameter value mappings doesn't make sense since the description would then be replicated to every value row. Re spine-tools/Spine-Toolbox#1892
soininen
force-pushed
the
toolbox_1892_description_mappings
branch
from
80def1c to
7c292aa
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #613 +/- ##
==========================================
+ Coverage 86.03% 86.05% +0.02%
==========================================
Files 83 83
Lines 11204 11225 +21
Branches 1627 1627
==========================================
+ Hits 9639 9660 +21
Misses 1210 1210
Partials 355 355 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds export mappings for entity class, entity and parameter descriptions.
Re spine-tools/Spine-Toolbox#1892
Checklist before merging