Add options that can be specified multiple times#35
Open
jeroenrnl wants to merge 2 commits intosplitbrain:masterfrom
Open
Add options that can be specified multiple times#35jeroenrnl wants to merge 2 commits intosplitbrain:masterfrom
jeroenrnl wants to merge 2 commits intosplitbrain:masterfrom
Conversation
Author
|
I see it failed on Unit Tests for PHP 7.2, 7.3, 7.4, this is due to using named options, however, 7.4 has been end-of-life for 1.5 years now, so I don't think that should still be supported... (8.0 is also already end-of-life) |
Owner
|
Sorry, this lib is used in legacy applications, so I want to keep compatibility. Can you adjust your code? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #31