Open
Conversation
lovasoa
requested changes
Jun 14, 2020
Member
lovasoa
left a comment
There was a problem hiding this comment.
Nice !
Two little things :
- it would be good if the example database would have a little more data, to let people play around with joins and filters. You can use for instance the Dallas Police Officer-Involved Shootings from this page: http://2016.padjo.org/tutorials/sqlite-data-starterpacks/
- The default query should be executed immediately once the database has been loaded.
Author
It's can be done. But about the hype: I prefer to use more neutral demo file. Do you have better option? |
Member
The Dallas Police Officer-Involved Shootings is great. It is small enough to load quickly, is not copyrighted, and contains interesting public data, with several tables that can be joined. If you find or create another database that meets these criteria and want to include it instead, go ahead; but I don't think the Dallas PD data has any reason for being controversial. |
zmwm37
added a commit
to zmwm37/react-sqljs-demo
that referenced
this pull request
Apr 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in previous PR I improved live-demo by add database file load example to become abilities run SQL queries on it.
Changes
fetchArrayBuffer=>Uint8Array)