Added proxy support for websocket connections#4635
Open
kauppine wants to merge 3 commits intosqlmapproject:masterfrom
Open
Added proxy support for websocket connections#4635kauppine wants to merge 3 commits intosqlmapproject:masterfrom
kauppine wants to merge 3 commits intosqlmapproject:masterfrom
Conversation
todlove
reviewed
Apr 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The websocket implementation in sqlmap did not use any proxy configurations provided via the commandline options.
This pull requests adds proxy support for websocket connections and also support for proxy-cred options. However, it does not support the proxy-file option.
With some limited testing, http, socks4 and socks5 options seems to work. However, https proxy option requires further investigation as it currently throws an error, which apparently relates to how websocket-client library handles proxies.