Merged
Conversation
Co-authored-by: contact <contact@ophir.dev>
Co-authored-by: contact <contact@ophir.dev>
Co-authored-by: contact <contact@ophir.dev>
Co-authored-by: contact <contact@ophir.dev>
|
Cursor Agent can help with this pull request. Just |
Co-authored-by: contact <contact@ophir.dev>
Co-authored-by: contact <contact@ophir.dev>
Co-authored-by: contact <contact@ophir.dev>
Co-authored-by: contact <contact@ophir.dev>
Collaborator
Author
|
@cursoragent If an user enters a port explicitly, then the port discovery logic should not kick in : pub struct MssqlConnectOptions {
pub(crate) host: String,
pub(crate) port: Option<u16>,So: if the user enters a port, then use it. If not, then either do port discovery, or use the default port. |
|
Perfect! I've updated the implementation to handle explicit ports correctly. Here's what changed: Changes Made1. Changed
|
Co-authored-by: contact <contact@ophir.dev>
Co-authored-by: contact <contact@ophir.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for SQL Server named instances to automatically resolve ports via SSRP.
This PR implements the SQL Server Resolution Protocol (SSRP) to discover the correct TCP port for named instances, allowing users to specify
instance=NAMEin connection strings. It correctly handles MBCS encoding for SSRP responses as per the specification.