Allow setting NotBefore property via init and sign commands#64
Open
jmecom wants to merge 1 commit intosquare:masterfrom
Open
Allow setting NotBefore property via init and sign commands#64jmecom wants to merge 1 commit intosquare:masterfrom
jmecom wants to merge 1 commit intosquare:masterfrom
Conversation
Contributor
|
It's kinda weird to call it "NotBefore", but it actually takes an offset from Now(). I'm not sure what exactly to do here. I'd expect NotBefore to take a date, I think. I wonder if we should use a different name for this, but I'm not sure what. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
notbeforeas an argument toinitandsignto allow setting NotBefore property. Ifnotbeforeis not supplied, theNotBeforewill be set as 10 minutes earlier than now. I believe this was intended to be the default behavior before, e.g.However,
Addtakes aDurationas an argument, which is anint64representing nanoseconds - so I don't think this behaved as described by the comment. I've changed the argument to-time.Minute * 10. Let me know if I should keep it as-is.