fix: Replace long running span with short lived spans#46
Merged
NickLarsenNZ merged 3 commits intomainfrom May 26, 2025
Merged
Conversation
Note: this has the added benefit of displaying the correct tracing target (or call-site), instead of displaying stackable_operator
Techassi
approved these changes
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before, the span lived as long as the app ran which is discouraged for (subjectively) long-running apps. This change moves the span to inside the loop, and move existing init stuff into a separate span (so that output is still distinguishable).
Also replace
stackable_operator::utils::print_startup_stringwithtracing::info!to get the correct call-site displayed.Why are long spans discouraged?
Two problems arise when troubleshooting an application via tracing:
Definition of Done Checklist
Author
Reviewer
Acceptance