-
Notifications
You must be signed in to change notification settings - Fork 0
ROX-32966: Add disabling label for the konflux retests #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| if: github.event_name == 'pull_request' | ||
| if: | | ||
| github.event_name == 'pull_request' && | ||
| !contains(github.event.pull_request.labels.*.name, 'disable-konflux-auto-retest') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Different event types and because of that a bit different label extraction
| github.event.check_run.conclusion == 'failure' && | ||
| startsWith(github.event.check_run.name, 'Red Hat Konflux') | ||
| startsWith(github.event.check_run.name, 'Red Hat Konflux') && | ||
| !contains(github.event.check_run.pull_requests[0].labels.*.name, 'disable-konflux-auto-retest') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we know that there is a least one PR associated with the check (see check above). My understanding is that the Konflux check might have multiple PRs only when the same commit is used in those PRs. I assume it's quite rare and unique scenario so I believe [0] is correct instead of * (we don't want to disable if at least one PR has label)
msugakov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding
No description provided.
Is there any way you can test this before merging to see if it really works?
I planned to test it with this PR, but looks like konflux is not starting for that repo ATM. https://github.com/stackrox/test-gh-actions/pull/236. Looks like this testing Konflux app was deleted. I will add a new one |
Testing: https://github.com/stackrox/test-gh-actions/pull/240