fix(tests): fix vi tests #270
Open
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the tests were written, the fedora:43 container being used had a symlink under `/usr/libexec/vi` that was being caught as the executable for the events being triggered. Once the tests were merged to main, it seems this behavior has changed and now the container uses `/usr/bin/vi` as the executable path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the tests were written, the fedora:43 container being used had a symlink under
/usr/libexec/vithat was being caught as the executable for the events being triggered. Once the tests were merged to main, it seems this behavior has changed and now the container uses/usr/bin/vias the executable path.If this behavior keeps changing for some reason, we might want to disable the
vitests altogether and relay on thevimtests instead, most modern systems just usevimin compatibility mode forvianyways.Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
Run the tests locally.