ROX-32852: Add filtering by cluster name #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
==========================================
+ Coverage 77.36% 78.22% +0.86%
==========================================
Files 26 27 +1
Lines 1162 1208 +46
==========================================
+ Hits 899 945 +46
Misses 223 223
Partials 40 40 ☔ View full report in Codecov by Sentry. |
mtodor
force-pushed
the
mtodor/ROX-32852-filter-by-cluster-name
branch
from
4ff363f to
3074da2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
==========================================
+ Coverage 77.36% 78.22% +0.86%
==========================================
Files 26 27 +1
Lines 1162 1208 +46
==========================================
+ Hits 899 945 +46
Misses 223 223
Partials 40 40 ☔ View full report in Codecov by Sentry. |
mtodor
force-pushed
the
mtodor/ROX-32852-filter-by-cluster-name
branch
from
3074da2 to
75abe25
Compare
mtodor
force-pushed
the
mtodor/ROX-32852-filter-by-cluster-name
branch
from
75abe25 to
f4bf6dd
Compare
janisz
reviewed
Feb 10, 2026
| client := v1.NewClustersServiceClient(conn) | ||
|
|
||
| // Use query to filter by cluster name server-side | ||
| query := fmt.Sprintf("Cluster:%q", clusterName) |
Contributor
There was a problem hiding this comment.
is it full or partial match? Should we do a check before returning the [0] element if name really matches?
janisz
approved these changes
Feb 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is adding filtering by cluster name.
It first fetches the cluster to verify that the name exists and then uses the actual cluster ID in the query for a backend call. In that way, we can properly return an error if the cluster name does not exist.
Validation