-
Notifications
You must be signed in to change notification settings - Fork 171
ROX-32012: Clean up remains of upstream OLM #18938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Skipping CI for Draft Pull Request. |
|
/test all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- The note about upstream OLM not working on GKE is now duplicated in the README; consider consolidating it into a single clearly visible section to avoid future divergence.
- Since
olm-install/olm-uninstalltargets and the OLM go-tool were removed, double-check for any remaining references to these targets or the OLM binary in other Makefiles or CI scripts to prevent broken workflows.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The note about upstream OLM not working on GKE is now duplicated in the README; consider consolidating it into a single clearly visible section to avoid future divergence.
- Since `olm-install`/`olm-uninstall` targets and the OLM go-tool were removed, double-check for any remaining references to these targets or the OLM binary in other Makefiles or CI scripts to prevent broken workflows.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Images are ready for the commit at eec47a8. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18938 +/- ##
==========================================
- Coverage 49.48% 49.48% -0.01%
==========================================
Files 2661 2661
Lines 200782 200782
==========================================
- Hits 99350 99348 -2
- Misses 94015 94017 +2
Partials 7417 7417
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/retest |
Description
olm-{un,}installtargets and go.mod entry, and add notes on OLM-GKE troubleUser-facing documentation
Testing and quality
Automated testing
How I validated my change
CI should be enough