Skip to content

Conversation

@porridge
Copy link
Contributor

@porridge porridge commented Feb 10, 2026

Description

  • Lower timeout for OLM prep, now that we are not installing is anymore.
  • Remove olm-{un,}install targets and go.mod entry, and add notes on OLM-GKE trouble

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • not modified existing tests

How I validated my change

CI should be enough

@openshift-ci
Copy link

openshift-ci bot commented Feb 10, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@porridge
Copy link
Contributor Author

/test all

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The note about upstream OLM not working on GKE is now duplicated in the README; consider consolidating it into a single clearly visible section to avoid future divergence.
  • Since olm-install/olm-uninstall targets and the OLM go-tool were removed, double-check for any remaining references to these targets or the OLM binary in other Makefiles or CI scripts to prevent broken workflows.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The note about upstream OLM not working on GKE is now duplicated in the README; consider consolidating it into a single clearly visible section to avoid future divergence.
- Since `olm-install`/`olm-uninstall` targets and the OLM go-tool were removed, double-check for any remaining references to these targets or the OLM binary in other Makefiles or CI scripts to prevent broken workflows.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@rhacs-bot
Copy link
Contributor

Images are ready for the commit at eec47a8.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.11.x-68-geec47a8393.

@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.48%. Comparing base (773e872) to head (eec47a8).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #18938      +/-   ##
==========================================
- Coverage   49.48%   49.48%   -0.01%     
==========================================
  Files        2661     2661              
  Lines      200782   200782              
==========================================
- Hits        99350    99348       -2     
- Misses      94015    94017       +2     
  Partials     7417     7417              
Flag Coverage Δ
go-unit-tests 49.48% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@porridge porridge marked this pull request as ready for review February 10, 2026 08:51
@porridge porridge requested review from a team as code owners February 10, 2026 08:51
@porridge porridge requested review from GrimmiMeloni and removed request for a team February 10, 2026 08:51
@porridge porridge added the auto-retest PRs with this label will be automatically retested if prow checks fails label Feb 10, 2026
@rhacs-bot
Copy link
Contributor

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review area/ci area/operator auto-retest PRs with this label will be automatically retested if prow checks fails

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants