Makes function signatures as explicit as possible#197
Open
chaburkland wants to merge 1 commit intostatic-frame:masterfrom
Open
Makes function signatures as explicit as possible#197chaburkland wants to merge 1 commit intostatic-frame:masterfrom
chaburkland wants to merge 1 commit intostatic-frame:masterfrom
Conversation
flexatone
approved these changes
Aug 11, 2025
Contributor
flexatone
left a comment
flexatone
left a comment
There was a problem hiding this comment.
Overall, these are great changes. I had not done this yet, as we were still testing on some old versions of Numpy did not support generic specification. I think, however, we should not have any issues... assuming we can get CI to pass!
| def get(self, __key: _TLabel, /,) -> int: ... | ||
| def keys(self) -> tp.Iterator[_TLabel]: ... | ||
| def items(self) -> tp.Iterator[tuple[_TLabel, int]]: ... | ||
| def items(self) -> tp.Iterator[tp.Tuple[_TLabel, int]]: ... |
Contributor
There was a problem hiding this comment.
Why not use tuple[_TLabel, int]] here?
Collaborator
Author
There was a problem hiding this comment.
It was for consistency in the file! Everywhere else used tp.Tuple so I changed it here too
Contributor
There was a problem hiding this comment.
ah, well, lets update them all to use tuple; tp.Tuple is deprecated!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.