Skip to content

(Towards #2381) Re-structure classes for reduction nodes.#3333

Merged
LonelyCat124 merged 37 commits intomasterfrom
2381_gredns_feb26
Feb 26, 2026
Merged

(Towards #2381) Re-structure classes for reduction nodes.#3333
LonelyCat124 merged 37 commits intomasterfrom
2381_gredns_feb26

Conversation

@arporter
Copy link
Member

No description provided.

@arporter arporter marked this pull request as draft February 16, 2026 15:53
@arporter arporter self-assigned this Feb 16, 2026
@codecov
Copy link

codecov bot commented Feb 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.95%. Comparing base (a7b7d27) to head (98492a6).
⚠️ Report is 38 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3333      +/-   ##
==========================================
- Coverage   99.95%   99.95%   -0.01%     
==========================================
  Files         384      386       +2     
  Lines       54271    54187      -84     
==========================================
- Hits        54249    54165      -84     
  Misses         22       22              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arporter arporter added enhancement LFRic PSyKAl-lite Issue related to removal of PSyKAl-lite code in LFRic labels Feb 18, 2026
@arporter
Copy link
Member Author

It looks like the Met Office has removed one of the pages that the tutorial used to point to so I've updated the link.
Ready for another look now.

@arporter
Copy link
Member Author

This time, the link-check failure is for a perfectly valid Issue on github so I think we can safely ignore it.

Copy link
Collaborator

@LonelyCat124 LonelyCat124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @arporter,

I'm not quite satisfied with the xfailing test - see inline.

@arporter
Copy link
Member Author

Ready for another look/discussion about the test.

@LonelyCat124
Copy link
Collaborator

Set CI running, otherwise I think everything is resolved.

Copy link
Collaborator

@LonelyCat124 LonelyCat124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI passed, ready to merge.

@LonelyCat124 LonelyCat124 merged commit df4a4f1 into master Feb 26, 2026
15 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in LFRic 25/26 Feb 26, 2026
@github-project-automation github-project-automation bot moved this from In Progress to Done in Remove LFRic PSyKAl-lite code. Feb 26, 2026
@LonelyCat124 LonelyCat124 deleted the 2381_gredns_feb26 branch February 26, 2026 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement LFRic PSyKAl-lite Issue related to removal of PSyKAl-lite code in LFRic ready to be merged

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants