(Closes #2202) Update the generation of Fortran declarations to observe dependencies#3344
Draft
(Closes #2202) Update the generation of Fortran declarations to observe dependencies#3344
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3344 +/- ##
==========================================
- Coverage 99.95% 99.95% -0.01%
==========================================
Files 384 384
Lines 54214 54205 -9
==========================================
- Hits 54192 54183 -9
Misses 22 22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
The NEMO ITs failed because of character variables: I was proceeding to try and do something with the parse tree in UnsupportedFortranType but actually, it would probably be better to work on populating the |
Member
Author
|
Marking this as blocked for the moment because I want to investigate adding support for a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a relatively simple PR - it takes the inter-dependence handling out of
_gen_param_declsand puts it intogen_decls. This also then means we can delete_gen_param_decls. I've added tests for the various tricky cases described in the original Issue and they all pass now :-)