Get benchmarks working on ubuntu#269
Merged
anish-mudaraddi merged 1 commit intomasterfrom Feb 26, 2026
Merged
Conversation
Contributor
RyanH-STFC
commented
Feb 25, 2026
RyanH-STFC
commented
- Change the script to get for what OS youre using and then use the correct package manager, and install the benchmarks the correct way.
RyanH-STFC
force-pushed
the
work-on-ubuntu
branch
9 times, most recently
from
6d1cc57 to
1a575ee
Compare
RyanH-STFC
force-pushed
the
work-on-ubuntu
branch
from
1a575ee to
ac7652c
Compare
khalford
requested changes
Feb 26, 2026
RyanH-STFC
force-pushed
the
work-on-ubuntu
branch
from
ac7652c to
587a197
Compare
khalford
previously approved these changes
Feb 26, 2026
celestyal
reviewed
Feb 26, 2026
gpu_benchmark/benchmark_setup.sh
Outdated
| # Copyright (c) 2026 United Kingdom Research and Innovation | ||
| set -ex | ||
|
|
||
| OS_NAME=$(awk -F= '/^NAME=/{gsub(""","",$2); print $2}' /etc/os-release) |
There was a problem hiding this comment.
The second speech mark will need escaping to avoid an error. So gsub(""","",$2) will become gsub("\"","",$2)
- Change the script to get for what OS youre using and then use the correct package manager, and install the benchmarks the correct way.
RyanH-STFC
force-pushed
the
work-on-ubuntu
branch
from
587a197 to
5876c10
Compare
anish-mudaraddi
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.