Heinrichs Weikamp OSTC 4/5: Fix the Firmware Version String.#101
Open
mikeller wants to merge 1 commit intosubsurface:Subsurface-DS9from
Open
Heinrichs Weikamp OSTC 4/5: Fix the Firmware Version String.#101mikeller wants to merge 1 commit intosubsurface:Subsurface-DS9from
mikeller wants to merge 1 commit intosubsurface:Subsurface-DS9from
Conversation
Remove the inconsistent newline at the end. Signed-off-by: Michael Keller <github@ike.ch>
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the OSTC 4/5 firmware version string formatting to remove an inconsistent trailing newline.
Changes:
- Removed the
\nsuffix from the formatted firmware version string for OSTC4 so the returned “FW Version” field is a plain version token without an embedded line break.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the inconsistent newline at the end.
Signed-off-by: Michael Keller github@ike.ch