Update laptop-battery-thresholds.md#1316
Open
zazesty wants to merge 2 commits intosystem76:masterfrom
Open
Conversation
Persistent battery charging thresholds were added to 2025-07-24 Open Firmware by writing to EC flash. I edited this article to reflect this, reworking a paragraph to inform folks with new firmware that they may change charge thresholds in a persistent manner via the terminal (obviating systemd), and guiding folks using older firmware to the systemd procedure. Thank y'all!
Contributor
|
I think some changes are not necessary: We are updating firmware often, so I feel it might be better to not explicitly name the firmware version |
Author
|
Yeah, that’s personal preference/style, not necessary to change. -ZavdiOn Oct 13, 2025, at 10:15 AM, garrettjwilke ***@***.***> wrote:garrettjwilke left a comment (system76/docs#1316)
I think some changes are not necessary:
changing This feature is not currently finished. to This feature is not fully finished. does not make things clear. It is either finished or it is not, adding fully finished does not make sense.
We are updating firmware often, so I feel it might be better to not explicitly name the firmware version 2025-07-24_c242738 would become outdated.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Member
|
I went ahead and simplified this. The note isn't really needed at the top anymore now that the feature's fully implemented in firmware. We can just mention where the workaround's needed in its own section. The GUI can be added to the article once it's implemented. |
leviport
approved these changes
Oct 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Persistent battery charging thresholds were added to 2025-07-24 Open Firmware by writing to EC flash.
I edited this article to reflect this, reworking a paragraph to inform folks with new firmware that they may change charge thresholds in a persistent manner via the terminal (obviating systemd), and guiding folks using older firmware to the systemd procedure.
my first pull request, please let me know if i should do something differently.
Thank y'all!