fix: make agent pre_authkey optional when disabled#476
Open
fix: make agent pre_authkey optional when disabled#476
Conversation
When integration.agent.enabled is false, pre_authkey should not be required. Added conditional validation using arktype's narrow().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #455
Problem
When using NixOS module with agent disabled, headplane fails to start because
pre_authkeyis required even whenenabled: false.Solution
Changed the agent config validation to only require
pre_authkeywhenenabledis true. Uses arktype'snarrow()for conditional validation.Changes
app/server/config/config-schema.ts- pre_authkey now optional with conditional checktests/unit/config/agent-disabled.test.ts- tests for disabled/enabled scenariosTesting