Fix definitions and statements in Section 7.2#449
Open
rkirov wants to merge 1 commit intoteorth:mainfrom
Open
Conversation
Contributor
rkirov
commented
Feb 18, 2026
rkirov
commented
- Fix Add/Sub instances: use min (not max) for starting index, matching Section 6.1 Sequence conventions. The max version silently drops terms from the lower-indexed series.
- Fix telescope (Lemma 7.2.15): flip subtraction to a_n - a_{n+1} (was a_{n+1} - a_n), matching Tao's statement.
- Fix unused variable warning in example_7_2_7
- Fix docstring typo: Example → Exercise 7.2.4
- Fix Add/Sub instances: use min (not max) for starting index,
matching Section 6.1 Sequence conventions. The max version
silently drops terms from the lower-indexed series.
- Fix telescope (Lemma 7.2.15): flip subtraction to a_n - a_{n+1}
(was a_{n+1} - a_n), matching Tao's statement.
- Fix unused variable warning in example_7_2_7
- Fix docstring typo: Example → Exercise 7.2.4
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rkirov
commented
Feb 18, 2026
| m := max a.m b.m | ||
| seq n := if n ≥ max a.m b.m then a.seq n + b.seq n else 0 | ||
| vanish n hn := by rw [lt_iff_not_ge] at hn; simp [hn] | ||
| m := min a.m b.m |
Contributor
Author
There was a problem hiding this comment.
note this matches the change we made in ff59747.
Also with max - Series.convergesTo.add is not even true. Consider, a = 2,0,0,0,0,0,... (a.m=0) and b = 0,1,0,0,0,0,0 (b.m = 1), with max (a+b).m = 1, so (a+b).sum = 1, while a.sum = 2 and b.sum = 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.